ParameterizeVariables returns false when no poses are present in the optimization#188
Open
gareth-cross wants to merge 1 commit intocolmap:mainfrom
Open
ParameterizeVariables returns false when no poses are present in the optimization#188gareth-cross wants to merge 1 commit intocolmap:mainfrom
gareth-cross wants to merge 1 commit intocolmap:mainfrom
Conversation
…ather than failing inside ceres
lpanaf
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an edge case that produces a confusing exception:
AddPointToCameraConstraintsadds no variables for the cameras.centeris never assigned in the loop ofParameterizeVariables. As a result,SetParameterBlockConstantis passed an address that Ceres is unfamiliar with, causing an exception to occur.This change explicitly checks for the case where no valid image variables were found, and returns false from
ParameterizeVariables. An error message is printed, rather than throwing an exception inside ceres.